Add support for generic version label parameter in plugins xml #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimasciput
approved these changes
Dec 27, 2024
Gustry
reviewed
Jan 7, 2025
Comment on lines
+75
to
+78
| url = 'https://version.qgis.org/version-ltr.txt' | ||
| elif param.lower() == 'latest': | ||
| url = 'https://version.qgis.org/version.txt' |
There was a problem hiding this comment.
A cleaner way and then instead of using re.search(r'QGIS Version \d+\|Visit .+ version (\d+\.\d+)', content), would be to switch to the JSON equivalent file :
https://version.qgis.org/version.json
It's way less prone to error of re.match, would you like to the do the change @Xpirix ?
There was a problem hiding this comment.
Good point @Gustry , I was not aware of this file before. Thank you.
The version.json just requires a small fix (qgis/QGIS-Website#513) so we can directly use the version attribute as it currently shows <no_value>.
There was a problem hiding this comment.
I've submitted the changes at #500
There was a problem hiding this comment.
Thanks, it's indeed more robust ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #448
latest,ltrandstable) in the plugin xml.generic-label-support.mov